Hi,
Looks good, tested with interactive service and without (netsh, ipapi).
A few questions:
> This also fixes an issue with --windows-driver wintun overriding
> --ip-win32 manual, the later being perfectly fine choice for Wintun too.
We do still have code which forces netsh for wintun:
if (options->windows_driver == WINDOWS_DRIVER_WINTUN)
{
options->tuntap_options.ip_win32_type = IPW32_SET_NETSH;
}
Shouldn't we update options.c and ensure that only allowed ip_win32
for wintun are manual, netsh and ipapi?
> - open_tun() & tuntap_post_open(): unify Wintun and TAP-Windows6 workflow.
With that change, we flush ARP cache also for wintun. Is this needed?
> This allows allows --ip-win32 ipapi now.
See above - we need to get rid of forcing netsh with wintun for that to work.
To test ipapi case, I had to comment out netsh forcing.
Also, while testing this I found (and fixed) a bug
(https://patchwork.openvpn.net/patch/1039/),
I think that fix should go first - your patch exposes bug (prints
device_guid value) for wintun case.
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
