Hi,

I must say I am not super familiar with this component nor MSI in general.

Stared at the code, compiled with MSVC and tested some exported
functions with rundll32.

This has removed lots of code, so it makes sense, assuming that all
required functionality is still in place.

It would be nice to have unit tests for msica_arg_* functions -
they're doing dangerous low-level stuff.

Acked-by: Lev Stipakov <lstipa...@gmail.com>


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to