Hi Tom, you forgot to CC the mailing list :-) I am adding it back.
On 24/03/2020 16:44, Tom van Leeuwen wrote: > On 24-03-2020 14:54, Antonio Quartulli wrote: >> Hi, >> >> On 24/03/2020 14:35, Gert Doering wrote: >>> Hi, >>> >>> On Tue, Mar 24, 2020 at 11:42:02AM +0100, Tom van Leeuwen wrote: >>>> When an mbedTLS session is moved in move_session(), the contents of the >>>> the tls_session is copied to the new session and the old session is >>>> reinitialized. This tls_session contains, amongst other things, an >>>> mbedtls_ssl_config and bio_ctx structure. However, the mbedtls context has >>>> internal pointers to the mbedtls_ssl_config and bio_ctx. When the session >>>> is moved, these internal pointers point to the reinitialized session. >> Can you explain, from an higher level perspective, what real/visible >> issue is this creating? i.e. do we have a crash under specific >> circumstances? do we have a key exchange failure at some point? >> >> How did you find the issue? >> > Hi, > > Sorry for the inconvenience, I am not used to the git-email workflow. > > The issue is described in issue 880: > https://community.openvpn.net/openvpn/ticket/880 > > Summarizing, if you configure a bind-port on a client and you kill the > client, you cannot reconnect again. > My patch would fix issue 880. I think that the information you reported is good material for the commit message. That would help the casual reader understanding what this patch wants to achieve, before describing the how. Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
