On 09/11/2019 16:13, Arne Schwabe wrote: > This implements sending AUTH_PENDING and INFO_PRE messages to clients > that indicate that the clients should be continue authentication with > a second factor. This can currently be out of band (openurl) or a normal > challenge/response 2FA like TOTP (CR_TEXT). > > Signed-off-by: Arne Schwabe <a...@rfc2549.org> > --- > doc/management-notes.txt | 26 +++++++++++++++++++++++ > src/openvpn/manage.c | 46 ++++++++++++++++++++++++++++++++++++++++ > src/openvpn/manage.h | 3 +++ > src/openvpn/multi.c | 19 +++++++++++++++++ > src/openvpn/push.c | 24 +++++++++++++++++++++ > src/openvpn/push.h | 2 ++ > 6 files changed, 120 insertions(+)
Code and management notes looks reasonable. But again, it would be good to have a way to test this properly to avoid regressions later on. Since this is also a more advanced authentication method, having good test methods is even more critical. -- kind regards, David Sommerseth OpenVPN Inc _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
