Hi, On Sun, Mar 29, 2020 at 07:58:15PM -0400, Selva Nair wrote: > Yes, that's right. However, that logic wont be proper on OS-X, would it? > Command line users who use --log can still see password > prompt on /dev/tty. We'll be breaking that behaviour. > > I considered checking for env vars like IV_UI_VER set by the UI > client, but that's not readily accessible from auth_user_pass_cr() > call. Alternatives like checking whether /dev/tty can be opened and/or > systemd is available didn't appeal to me. If at all, that would have > to be a separate patch.
Not sure if the case "there is an active management client, and
--management-query-passwords is set, but we *could* ask on /dev/tty"
is really worth considering.
(There might be cases where the management interface is not used
for password prompting, in which case /dev/tty is the way to go).
Not sure I'd worry too much about systemd here - as far as I understand,
this is somewhat orthogonal to "management interface". So if run from
systemd, and querying via systemd, you have no management client
connected.
Am I making sense? It's monday morning, halfway through my first cup
of tea :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
