Hi, On 27/04/2020 03:57, Arne Schwabe wrote: > Am 22.04.20 um 11:26 schrieb Antonio Quartulli: >> Carrying around the INLINE_TAG is not really efficient, >> because it requires a strcmp() to be performed every >> time we want to understand if the data is stored inline >> or not. >> >> Convert all the *_inline attributes to bool to make the >> logic easier and checks more efficient. >> > > Look through it. It is only a minor improvement but Antonio has been > persistent enough and spend enough time to make 9 versions of this so I > took the time to look through it: > > Acked-By: Arne Schwabe <arne@rfc2549> > > The patch is not uncrustify clean at the moment. So uncrustify should be > run on commit or we need a v10 of this patch. > > The patch does not apply cleanly anymore: The test_tls_crypt.c part > should be now.
I can send v10 with these adjustments. Thanks for the review! -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
