I'm getting this failure of test_ncp.c
[ RUN ] test_check_ncp_ciphers_list
[ ERROR ] --- 0x7d67e8 != 0
[ LINE ] --- test_ncp.c:65: error: Failure!
[ FAILED ] test_check_ncp_ciphers_list
I'm building under openssl-1.1.0i
The problem seems to be openssl uses a mixed case name for the cipher
and EVP_CIPHER_name() is case sensitive. Applying the patch below
fixes this for openssl and gets make check to pass all tests, but I
rather wonder why this isn't part of cipher_kt_name() to prevent this
type of problem?
James
---
diff --git a/tests/unit_tests/openvpn/test_ncp.c
b/tests/unit_tests/openvpn/test_ncp.c
index 19432410..f58fa2ea 100644
--- a/tests/unit_tests/openvpn/test_ncp.c
+++ b/tests/unit_tests/openvpn/test_ncp.c
@@ -48,7 +48,7 @@ static void
test_check_ncp_ciphers_list(void **state)
{
struct gc_arena gc = gc_new();
- bool have_chacha = cipher_kt_get("CHACHA20-POLY1305");
+ bool have_chacha =
cipher_kt_get(translate_cipher_name_from_openvpn("CHACHA20-POLY1305"));
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
