Hi,
On 07/07/2020 14:16, Arne Schwabe wrote:
> Instead of having the whole function as
>
> if (x) { func }
>
> do
>
> if (!x) func
I guess this commit message needs some love? You probably meant:
Instead of..
if (x) { func }
do
if (!x) return;
func
At least, this is what the patch does :-)
>
> Due to the whitespace changes in the function body this patch looks
> very strange. Ignoring whitespace makes the diff look sane.
>
> Signed-off-by: Arne Schwabe <a...@rfc2549.org>
I am super-pro this style.
It makes the whole function easier to read and saves a lot of horizontal
spaces by killing one level of indentation.
Reviewing this patch with "git show -w" makes it super obvious.
No functional change included, the patch is just reverting the top
condition and returning right away.
Stared at the code and compile-tested. (but please fix the commit
message before merging)
Acked-by: Antonio Quartulli <a...@unstable.cc>
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
