Hi,

On 13/07/2020 13:29, Gert Doering wrote:
> instead, maybe this?
> 
>> +        const char *ccd_client = 
>> +             platform_gen_path(mi->context.options.client_config_dir,
>> +                               tls_common_name(mi->context.c2.tls_multi,
>> +                                               false), &gc);
> 

I also like the above.

> or maybe we want to extract "tls_common_name(..., false)" into a temp
> variable here? 
> 
>> +        const char *cn = tls_common_name(mi->context.c2.tls_multi, false);
>> +        const char *ccd_client = 
>> +             platform_gen_path(mi->context.options.client_config_dir, 
>                                   cn, &gc);
> 

Imho this is not prettier than the version above :D so I'd personally go
with the version above instead of this.


Cheers,


-- 
Antonio Quartulli


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to