Hi,

On Sun, Jul 19, 2020 at 10:05:54PM +0200, Gert Doering wrote:
[..]
> the fact that it's reading the "client specific options" even in case of 
> failure is clear form the source (but I decided that it won't do harm, so 
> "leave it in") but the fact that it's not logging the failure is not good - 
> so 
> I think we need to differenciate CC_RET_SUCCEEDED vs. CC_RET_FAILED in the 
> "if (ret != CC_RET_DEFERRED)" clause in in 
> multi_client_connect_script_deferred().
> 
> Since this is logging, and basic functionality works, I think this can go in 
> a followup patch.

Just for the record: this has been addressed in commit 3658e5779.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to