Am 22.07.20 um 11:54 schrieb David Sommerseth:
> Before --link-mtu, it was --udp-mtu. This was changed in
> OpenVPN 1.5_beta1 (release July 2003). It should be safe now
> to remove --udp-mtu, the transition period should have been long
> enough.
>
> Signed-off-by: David Sommerseth <dav...@openvpn.net>
> ---
> src/openvpn/options.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/openvpn/options.c b/src/openvpn/options.c
> index b1962ca4..3ebf033d 100644
> --- a/src/openvpn/options.c
> +++ b/src/openvpn/options.c
> @@ -3645,7 +3645,6 @@ calc_options_string_link_mtu(const struct options *o,
> const struct frame *frame)
> * --dev tun|tap [unit number need not match]
> * --dev-type tun|tap
> * --link-mtu
> - * --udp-mtu
> * --tun-mtu
> * --proto udp
> * --proto tcp-client [matched with --proto tcp-server
> @@ -6007,7 +6006,7 @@ add_option(struct options *options,
> goto err;
> }
> }
> - else if ((streq(p[0], "link-mtu") || streq(p[0], "udp-mtu")) && p[1] &&
> !p[2])
> + else if (streq(p[0], "link-mtu") && p[1] && !p[2])
> {
> VERIFY_PERMISSION(OPT_P_MTU|OPT_P_CONNECTION);
> options->ce.link_mtu = positive_atoi(p[1]);
> I close to sending a NAK to this. Normally we just don't outright remove options but rather warn for a version or two. But adding the warning code here and later removing the option just to remove the complexity of '|| streq(p[0], "udp-mtu"'? I don't see a compelling reason to remove alias option. Normally we deprecate options because they - are considered harmful in some way (no-iv) - complicate the code without a clear gain - are replaced by a better mechanism and the old option does not trivally translate to the new option. - are features that we do no longer want to maintain and to remove them to decrease complexity (--enable-client-only) But with alias I feel we just removing them because we found a newer nicer name and as a user (especially another dev) removing an alias feels like they are removed because of pride/principle that since they are old they must be go away. I cannot came up with any other compelling reason why we need to remove them. And as much as I want to have old options gone as well, if my only reason is pride/they are old then I have to say that they should stay while the option they alias also stays. Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
