Hi, On Fri, Jul 24, 2020 at 02:26:31PM +0300, Lev Stipakov wrote: > From: Lev Stipakov <l...@openvpn.net> > > Body of check_subnet_conflict() was commented out > (#if 0) back in 2011, so it is safe now to completely > elimitate this function, including all calls to it.
I'm a bit sceptical about that one. Can we make it *work* instead? It's a good idea, and I've seen support calls with "hey, openvpn is not working, why?" due to RFC address conflict - so having an indication in the log might be helpful. I agree that with "#if 0" this is just dead code. Any indication in the commit why it was commented out? Not working right? gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel