Acked-by: Gert Doering <g...@greenie.muc.de>
Thanks for the v2. Builds nicely with "./build-snapshot" on my
ubuntu 18.04 builder now. I have not tested the resulting installer.
The code change for the C code look good to me.
Thanks for the explanation about the manifest ("I've heard that
before, but I won't ever become a windows programmer, it seems"),
and I assume that the .vcproj adaptions are related to that.
You are the expert on MSVC building, so if you say this is needed,
and it does not look harmful, I'm fine :-)
Your patch has been applied to the master branch.
commit a7d6977e6e14c512c89e51886b235af153cd4841
Author: Lev Stipakov
Date: Fri Jul 24 22:56:34 2020 +0300
Improve Windows version detection with manifest
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20200724195634.493-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20580.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
