Acked-by: Gert Doering <g...@greenie.muc.de>

This is magic :-) - it's just a one liner (plus lots of documentation)
but the description makes sense, staring at the code for a while also
makes sense.  Plus, it works :-)

I have not tested the server side, as (to my understanding) this is 
basically "client side only" code.  I *have* tested p2p with --tls-client
(now! part of my t_client rig :-) ) and that still works - relevant, as
the code flows along the "established?  send pull?" path here.

The new code also works correctly with pre-fast-pull servers (the
"reference server" is - because I'm lazy - still running an older 
version).

I have merged the typo fixes from Richard as well (note: ommitted has
only one m!  I asked google!), and done a bit more bragging in the
Changes.rst wording ("significantly! improves connection time!").

Your patch has been applied to the master branch.

commit a3b21a76b87fedf045c409481f55c34486d8cd27
Author: Arne Schwabe
Date:   Sun Jul 26 01:48:03 2020 +0200

     Avoid sending push request after receving push reply

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20200725234803.22058-2-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20589.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to