Am 27.07.20 um 20:34 schrieb Gert Doering: > The old code would run all (succeeding) handlers, then discover "one of > them set the 'disable' flag for this client", and then unroll all the > handlers. > > Moving the 'disable' check into the loop makes it stop after the first > handler that fails or (succeeds and sets 'disable'). This is a bit > more logical in the log files, and has less potential side effects > due to running "later" client-connect handlers when we already know > they will have to be unrolled. > > Signed-off-by: Gert Doering <[email protected]>
This another of the 'review is easy if you ignore white space' patches. This slightly changes the behaviour but I don't see a problem with the behaviour change to abort early. Acked-By: Arne Schwabe <[email protected]>
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
