Hi, This looks good but can we do better? We don't check the error (GetLastError()) after the CreateFile() failure -- can we determine whether the error was due to permissions, busy file (in use) or disabled device and print out a more specific error message? I'm not sure what errors are triggered by CreateFile, so just wondering..
Selva On Thu, Aug 6, 2020 at 3:02 PM Richard Bonhomme <tincantek...@gmail.com> wrote: > > Ref: https://github.com/OpenVPN/openvpn-gui/issues/356 > > Signed-off-by: Richard Bonhomme <tincantek...@gmail.com> > --- > src/openvpn/tun.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c > index cc7b65cf..44ca8450 100644 > --- a/src/openvpn/tun.c > +++ b/src/openvpn/tun.c > @@ -6436,7 +6436,7 @@ tun_open_device(struct tuntap *tt, const char > *dev_node, const char **device_gui > > if (!*device_guid) > { > - msg(M_FATAL, "All %s adapters on this system are currently > in use.", print_windows_driver(tt->windows_driver)); > + msg(M_FATAL, "All %s adapters on this system are currently > in use or disabled.", print_windows_driver(tt->windows_driver)); > } > > if (tt->windows_driver != windows_driver) > -- > 2.17.1 > > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
