Acked-by: Gert Doering <[email protected]>
Server-side and client-side tested.
Not sure if I understand all possible implications of S_NORMAL_OP,
but indeed it is not *used* anywere, except in ">= S_ACTIVE".
The flow of "at which point in time we set must_negotiate = 0"
changes a bit - the old code would do it "when it expired AND
we're in >= S_ACTIVE", while the new code would do it "right
when setting S_ACTIVE" - which is the only place where S_ACTIVE
is set, so it would always catch said condition. This should be
totally fine.
Your patch has been applied to the master branch.
commit c13d20fae3961ba67de3c4c85c75ebd1ac802b26
Author: Arne Schwabe
Date: Mon Aug 10 16:37:03 2020 +0200
Remove S_OP_NORMAL key state.
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg20674.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
