Am 05.08.20 um 11:02 schrieb Lev Stipakov: > Hi, > > + ASSERT(snprintf(ifname, sizeof(ifname), "utun%d", utunnum)); > > Not sure about ASSERT here, because according to > https://linux.die.net/man/3/snprintf > >> If an output error is encountered, a negative value is returned. > > which won't trigger assert. > > Otherwise looks good. > > Compiled and tested on macOS. > > Maybe Gert could remove ASSERT wrapping before commiting. > > Acked-by: Lev Stipakov <lstipa...@gmail.com> >
You are too late, there is already a v2 that fixed that problem and is merged :) Arne _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
