On 03/09/2020 13:44, Vladislav Grishenko wrote:
> According client-options.rst additional argumets ``port`` and ``proto``
> are both optional and it's allowed to have port absent and protocol set:
>     --remote args
>       Examples:
>          remote server.example.net tcp
> 
> But when protocol is set without preceeding port argument, it is being
> misparsed as a port with subsequent error:
>     RESOLVE: Cannot resolve host address: server.example.net:tcp
>     (Servname not supported for ai_socktype)
> 
> Since protocol names are predefined and don't match service names, fix
> this behavior by checking second argument for valid protocol first.
> 
> Signed-off-by: Vladislav Grishenko <themi...@yandex-team.ru>
Uhm ... I'm leaning towards a NAK to this patch and would rather suggest
updating the man page to be correct.  This is a mistake from my side when
converting the man page to .rst files.  The example should be:

       remote server.example.net 1194 tcp

The OpenVPN 2.4 and prior releases has this line:

       --remote host [port] [proto]

But this syntax was not supported by rst2man, so it was replaced with "args"
and the examples coming below; which carried an error.


-- 
kind regards,

David Sommerseth
OpenVPN Inc


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to