Hi On Tue, Sep 15, 2020 at 2:48 AM Lev Stipakov <lstipa...@gmail.com> wrote:
> Hi, > > > - msg(M_USAGE, "--dhcp-options requires --ip-win32 dynamic or > adaptive"); > > + msg(M_USAGE, "--dhcp-option requires --ip-win32 dynamic or > adaptive"); > > Nice, this typo has been there since at least 2005. > > It looks like that warning is not quite correct - for example, > DNS can be set via iservice or netsh, which means that > > --ip-win32 netsh > --dhcp-option DNS 8.8.8.8 > > is a valid combination regardless of driver type. On the other hand, > NBDD/NTP are set via DHCP. > > It would be good to make the warning condition more fine-grained, but > this patch is good enough as it is, since it fixes important case - specify > DNS in the ovpn profile when using wintun. > We could deprecate --ip-win32 as a user option. Default to dynamic or adaptive, automatically fail-over to alternate methods or change it internally as required for wintun etc. And work towards supporting more dhcp-options when dhcp is not possible -- using iservice, API, netsh etc. Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
