Acked-by: Gert Doering <[email protected]>
I think this is a good first patch for the problem at hand, and it
might actually fix one of our (old!) open trac tickets, claiming that
the shaper is not (always) working correctly on Linux - Trac#91
For master, we should look more closely into always using "one of
the usec providing" time functions, and not mixing time() and
gettimeofday() - at least on platforms where this can be done
without adverse effects, even if virtualization is involved
(making *some* time related functions horribly slow).
I have read the context (otime.h, otime.c), agree with your
conclusions, *and* have tested it client-side on Linux and
FreeBSD - nothing broke. I have not tested the shaper.
Your patch has been applied to the master and release/2.5 branch.
commit e9e47f498674f6db8c3b88b32c877c5beb09a888 (master)
commit 51ee3574faade4dae5762140ea9f3a5eadc9d1e3 (release/2.5)
Author: Vladislav Grishenko
Date: Tue Sep 22 22:08:41 2020 +0500
Fix update_time() and openvpn_gettimeofday() coexistence
Signed-off-by: Vladislav Grishenko <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg21070.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
