Am 03.07.19 um 16:50 schrieb Daniel Kaldor:
> OpenVPN using management interface and running with
> 'management-query-remote' in the config will wait for a 'remote MOD'
> or 'remote ACCEPT' message before continuing with connection.
>
> Logs indicate that this stage of the connection process currently
> takes ~1s to complete.
> This seems to be because the management interface polling loop is
> being run once unnecessarily after receiving 'remote MOD' message, and
> is only exiting after 1s timeout is reached on final polling loop.
>
> This change exits the polling loop early, immediately after receiving
> 'remote MOD' message and removes 1s delay in connection.
>
>
> ---
> src/openvpn/manage.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
> index 2d86dad..7343e8b 100644
> --- a/src/openvpn/manage.c
> +++ b/src/openvpn/manage.c
> @@ -3348,7 +3348,13 @@ management_event_loop_n_seconds(struct
> management *man, int sec)
> /* run command processing event loop */
> do
> {
> - man_standalone_event_loop(man, &signal_received, expire);
> + int status = -1;
> +
> + status = man_standalone_event_loop(man, &signal_received,
> expire);
> + if (status > 0)
> + {
> + return;
> + }
> if (!signal_received)
> {
> man_check_for_signals(&signal_received);I have no doubt that the patch fixes your particular problem but it modifies the management loop to exit early for all commands and this feels it could cause trouble for other commands. Did you test anything other your use case? Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
