Your patch has been applied to the master branch.
Client-side tested, and lightly stared at the code.
The whitespace dragon made me add that blank after comma (but not
the other one in code not already touched by this patch) - IRC
discussion points to "sp_after_comma", which we indeed do not set
today. We need to discuss this with the dragons :-)
After quite some deliberation I've decided that this is "new feature"
and "too late for 2.5", so not applied to release/2.5 - it was not
an easy decision, as this could indeed be a very useful feature for
server operators running "distribution provided" binaries, which
usually is "2.5". OTOH, at some point we want to get 2.5.0 *out*,
and if we keep adding features, we need more RCs, and then we'll
never get there. OTOH, again, this is a fairly isolated change - so
if enough users yell at me that THEY MUST HAVE THIS, we could put
it in 2.5.1 or 2.5.2 ("small and isolated new features can be done
in small-numbered subreleases").
Also, we do want 2.6.0 to happen "soonish" this time, like "in one
year, not in four years". Let's see...
commit 3b04c34de140355b5b1d4ed85f7ccf1db9b0135d
Author: Vladislav Grishenko
Date: Mon Oct 5 05:51:14 2020 +0500
Support X509 field list to be username
Signed-off-by: Vladislav Grishenko <themi...@yandex-team.ru>
Acked-by: Arne Schwabe <a...@rfc2549.org>
Message-Id: <20201005005114.13619-1-themi...@yandex-team.ru>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21168.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
