Hi,

On Tue, Dec 15, 2020 at 06:16:00PM +0100, Domagoj Pensa wrote:
> When registering DNS on Windows, argv is freed after being used in first
> ipconfig command (/flushdns).
> 
> Then same argv is used uninitialized in next ipconfig command (/registerdns)
> causing heap exception and subprocess crash.
> 
> As a consequence second command is never executed and locked netcmd
> semaphore is not cleanly released.
> 
> Removing argv freeing between ipconfig calls solves the problem.

Oh!  Yes, now with your patch, this is very obvious - there is a trac
ticket (so when I merge this, I'll add the trac ticket number to the
commit message) but it sort of puzzled Selva and me, because the
code "looked sane".

Acked-by: [email protected]

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to