Hi,
Please not that I got errors applying this patch, so I reviewed
corresponding commit
from github
(https://github.com/schwabe/openvpn/commit/3901e46127a2db3e6dfb20c44e8d8e30adea58c7).
> +Receiving a AUTH_PENDING message will make the client change its timeout the
> +timeout proposed by the server, even if the timeout is shorter.
Typo.
> /*
> * min/max functions
> */
> +static inline unsigned int
> +max_uint(unsigned int x, unsigned int y)
It is 2021 and we have to write our own min/max :(
> + while (buf_parse(&buf, ',', line, sizeof(line)))
> + {
> + if (sscanf(line, "timeout %u", server_timeout) == 1)
> + {
> + ;
> + }
This looks odd. Why not reverting if and getting rid of this empty
"then" branch?
> + time_t peer_last_packet; /* Last time we received a paket in this
> control session */
Typo.
Thanks for the in-line comments, code is much nicer to read this way.
Waiting for typo fixes and rebase to ACK.
--
-Lev
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
