Hi,
> +platform_ret_code(int stat)
> +{
> +
> + if (stat >= 0 && stat < 255)
Unneeded line break.
> -/* interpret the status code returned by execve() */
> +/** interpret the status code returned by execve() */
> bool platform_system_ok(int stat);
>
> +/** Return a return code if valid and between 0 and 255, -1 otherwise */
> +int platform_ret_code(int stat);
"Return a return code" looks odd. Maybe "status code" or "exit code" ?
> + if(flags & S_EXITCODE)
Missing whitespace after if.
> +/**
> + * Will run a script and return the exit code if it
> + */
"If it" what?
Assuming committer will fix those nit-picks (especially last one),
Acked-by: Lev Stipakov <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
