Your patch has been applied to the master branch.
I'm not sure I understand the code, though. It receives the new timeout
from the server (that is easy), but then caps it by "hand_window", which
is never increased - so the maximum timeout stays at "60", unless increased
manually on the client. Where am I misreading this? Or is this a
prerequisite for this functionality?
c->c2.push_request_timeout = ks->established + min_uint(max_timeout,
server_timeout);
(or am I totally misunderstanding push_request_timeout, and this has
nothing to do with hand-window, except "it's using this as a default
value", but only for triggering re-sends, not for "final give up"?)
However, for my standard test cases, this does not break anything, and
the code looks reasonable. So in it goes :)
commit 3f8fb2b2c1d664f421d36181846da89c4330c6cc
Author: Arne Schwabe
Date: Mon Jan 25 13:56:19 2021 +0100
Implement client side handling of AUTH_PENDING message
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Lev Stipakov <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg21491.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
