Hi, On Mon, Feb 01, 2021 at 04:03:40PM +0100, Arne Schwabe wrote: > This prepares send_auth_pending_messages to be used a in context that > does not have context c available but also does not need to schedule > an immediate sending of the message (auth plugin/script) > > Patch V2: Adjust the comment of reschedule_multi_process to actually fit a > function. > Patch V3: Rebase needed because v3 of 3/11
The change itself is good, and basically just moving around things a bit
(different calling convention, so no more "c" available, thus calling
"send_control_channel_string_dowork()" instead of the other function,
*thus* needing to call interval_action() in the caller, which is easier
if folded into reschedule_multi_process(). So, ACK on the intention.
Alas, the v3 patch does not compile :-( - so "Changes Requested".
../../../openvpn/src/openvpn/push.c:366:1: error: conflicting types for
'send_auth_pending_messages'
366 | send_auth_pending_messages(struct tls_multi *tls_multi, const char
*extra,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../openvpn/src/openvpn/push.c:32:
../../../openvpn/src/openvpn/push.h:81:1: note: previous declaration of
'send_auth_pending_messages' was here
81 | send_auth_pending_messages(struct context *c, const char *extra,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
changing of the prototype in push.h is missing.
That said, the patch also introduces two extra blank lines, which I would
have fixed on-the fly - but if you re-send anyway with push.h fixed, please
fix that, too :-)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
