On 18/03/2021 12:14, Илья Шипицин wrote:
this probably will break windows cross compile (it uses lz4 bundle).

Samuli, can you please keep any eye on it  (new test installer maybe) ?

Is it too early to consider --disable-lz4 all together? Maybe try that initially for the 2.6 and see how well it is received by beta/rc testers. And further, for 2.7 we can consider having --enable-comp-stub by default.

I can do a similar move with the Fedora Copr openvpn-git development builds.


--
kind regards,

David Sommerseth
OpenVPN Inc



чт, 18 мар. 2021 г. в 12:45, Gert Doering <g...@greenie.muc.de <mailto:g...@greenie.muc.de>>:

    Acked-by: Gert Doering <g...@greenie.muc.de
    <mailto:g...@greenie.muc.de>>

    I have tested compilation "with default options" on FreeBSD with lz4
    (works), Gentoo without lz4 (errors out), Gentoo with lz4 (works), and
    with --disable-lz4 on Gentoo without lz4 (works).

    I assume some of the buildbots will need a bit of tending now (because
    "no lz4 installed, since we bundle it anyway").  They will tell me...

    Your patch has been applied to the master branch.

    commit 24596b258aa3a9c0bd79e7e7bd4753c48a435408
    Author: David Sommerseth
    Date:   Wed Mar 17 23:06:42 2021 +0100

          build: Remove compat-lz4

          Signed-off-by: David Sommerseth <dav...@openvpn.net
    <mailto:dav...@openvpn.net>>
          Acked-by: Gert Doering <g...@greenie.muc.de
    <mailto:g...@greenie.muc.de>>
          Message-Id:
    <20210317220642.38741-1-open...@sf.lists.topphemmelig.net
    <mailto:20210317220642.38741-1-open...@sf.lists.topphemmelig.net>>
          URL:
    
https://www.mail-archive.com/search?l=mid&q=20210317220642.38741-1-open...@sf.lists.topphemmelig.net
    
<https://www.mail-archive.com/search?l=mid&q=20210317220642.38741-1-open...@sf.lists.topphemmelig.net>
          Signed-off-by: Gert Doering <g...@greenie.muc.de
    <mailto:g...@greenie.muc.de>>


    --
    kind regards,

    Gert Doering



    _______________________________________________
    Openvpn-devel mailing list
    Openvpn-devel@lists.sourceforge.net
    <mailto:Openvpn-devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/openvpn-devel
    <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>



--
kind regards,

David Sommerseth
OpenVPN Inc



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to