Acked-by: Gert Doering <[email protected]>
Just *looking* at these functions with the insane number of arguments
make my head hurt. So I can't claim to have thoroughly reviewed that
every single argument goes to wherever it wanted to go before. What
I saw looked good, though.
BUT - we have good test coverage on these (tcp, udp, socks, http proxy,
ipv4, ipv6) in the t_client test set. So I let my machines worry :-)
Linux and FreeBSD both claim that the end result still works
(it might have broken the SRV patch, but we'll see).
Your patch has been applied to the master branch.
commit 343b61195b76796632b8948674fd1068889bb6c7
Author: Arne Schwabe
Date: Thu Apr 1 15:13:37 2021 +0200
Remove do_init_socket_2 and do_init_socket_1 wrapper function
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg21954.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
