Your patch has been applied to the master branch.

I have never looked into this reliable stuff before, and do not have
a test environment with a) significant amounts of control plane traffic,
and b) "just the right amount" of packet loss.  So I've just stared at
the code a bit (seems reasonable) and tested client side on Linux
(works).

I do wonder a bit under which condition this could fire - with the
larger control channel packets we introduced a few years ago, I do
not see many scenarios where "more than 3 packets" could be in-flight
at the same time...  inital TLS handshake with very large DH groups?

commit 203afbe95ee324ec941e35399f6655dc4f669f12
Author: Steffan Karger
Date:   Wed Mar 31 20:03:23 2021 +0200

     reliable: retransmit if 3 follow-up ACKs are received

     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Message-Id: <e1lrfw3-0001sy...@sfs-ml-4.v29.lw.sourceforge.com>
     URL: 
https://www.mail-archive.com/search?l=mid&q=e1lrfw3-0001sy...@sfs-ml-4.v29.lw.sourceforge.com
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to