Hi, On Wed, Mar 17, 2021 at 02:03:12PM +0100, Arne Schwabe wrote: > This patch also refactors the if condition that checks the result of > the authentication since that has become quite unreadable. It renames > s1/s2 and extracts some parts of the condition into individual variables > to make the condition better understandle > > Patch v2: add refactoring of the if condition > Patch v4: fix documentation not mentioning method as 2nd line > Patch v5: fix deferred auth used by both plugin and script not working > > Signed-off-by: Arne Schwabe <[email protected]>
Looking at the --enable-async-push fix-patch, it seems that this one
also needs to add an inotify watch for ks->script_auth.auth_control_file,
no?
Haven't tested the rest yet. First glance looks good, but without
"dual-inotify" this looks incomplete.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
