> I like the new approach a lot. > It definitely helps keeping track of "what compat code do we need? and > for which version?" > > Just one suggestion: > I think it would still be useful to add a comment on the #endif line to > explicitly say what if we are closing. > > i.e: > > #endif /* OPENSSL_VERSION_NUMBER < 0x10101000L && > !defined(ENABLE_CRYPTO_WOLFSSL) */ > > That helps your brain when the corresponding #if is far away or you have > more than one nearby. > >\
Just running uncrustify on the file will just add that one comment -#endif +#endif /* if OPENSSL_VERSION_NUMBER < 0x10100000L && !defined(ENABLE_CRYPTO_WOLFSSL) */ So if that can be done at commit time that would avoid a V2 but I can also send a V2 with only that change if that is preferred. Arne _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
