Acked-by: Gert Doering <g...@greenie.muc.de>

We discussed the feature-ACK part in the last community meeting - this
is for (Android) clients "everything that runs while the VPN is active"
should use an http proxy.  This is installed by the VPN API and "just
passed through" through OpenVPN.

The new code is all #ifdef TARGET_ANDROID, so if you say this is good,
we're not to doubt it :-) (but it looks reasonably safe).  The argument
count change is (unfortunately) necessary but also looks good.

I have run a t_client test run, but that didn't excercise the DHCP
code much.

Your patch has been applied to the master branch.

commit 8d109f68fd277b3e00ba7bef61a172b4130c35b8
Author: Arne Schwabe
Date:   Fri Apr 16 13:09:55 2021 +0200

     Add parsing of dhcp-option PROXY_HTTP

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20210416110955.1162574-1-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22129.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to