From: Arne Schwabe <a...@rfc2549.org>
Changes from v1:
- fixed typ0s
- extended comment
- moved *_SHIFT definition to openvpn.h
- made READ/WRITE events dependant on _SHIFT definition with a macro
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
---
Passed all compile tests on my GitLab CI. (including enabling/disabling
mgmt and async push)
src/openvpn/forward.c | 14 +++++++-----
src/openvpn/openvpn.h | 51 ++++++++++++++++++++++++++++++++++---------
2 files changed, 49 insertions(+), 16 deletions(-)
diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c
index df96d048..e302d8e0 100644
--- a/src/openvpn/forward.c
+++ b/src/openvpn/forward.c
@@ -1867,15 +1867,17 @@ io_wait_dowork(struct context *c, const unsigned int
flags)
unsigned int tuntap = 0;
struct event_set_return esr[4];
- /* These shifts all depend on EVENT_READ and EVENT_WRITE */
- static int socket_shift = 0; /* depends on SOCKET_READ and SOCKET_WRITE
*/
- static int tun_shift = 2; /* depends on TUN_READ and TUN_WRITE */
- static int err_shift = 4; /* depends on ES_ERROR */
+ /* These shifts all depend on EVENT_READ (=1) and EVENT_WRITE (=2)
+ * and are added to the shift. Check openvpn.h for more details.
+ */
+ static int socket_shift = SOCKET_SHIFT;
+ static int tun_shift = TUN_SHIFT;
+ static int err_shift = ERR_SHIFT;
#ifdef ENABLE_MANAGEMENT
- static int management_shift = 6; /* depends on MANAGEMENT_READ and
MANAGEMENT_WRITE */
+ static int management_shift = MANAGEMENT_SHIFT;
#endif
#ifdef ENABLE_ASYNC_PUSH
- static int file_shift = 8; /* listening inotify events */
+ static int file_shift = FILE_SHIFT;
#endif
/*
diff --git a/src/openvpn/openvpn.h b/src/openvpn/openvpn.h
index a15ff08d..02eede92 100644
--- a/src/openvpn/openvpn.h
+++ b/src/openvpn/openvpn.h
@@ -232,16 +232,47 @@ struct context_2
int event_set_max;
bool event_set_owned;
- /* event flags returned by io_wait */
-#define SOCKET_READ (1<<0)
-#define SOCKET_WRITE (1<<1)
-#define TUN_READ (1<<2)
-#define TUN_WRITE (1<<3)
-#define ES_ERROR (1<<4)
-#define ES_TIMEOUT (1<<5)
-#define MANAGEMENT_READ (1<<6)
-#define MANAGEMENT_WRITE (1<<7)
-#define FILE_CLOSED (1<<8)
+ /* event flags returned by io_wait.
+ *
+ * All these events are defined as bits in a bitfield.
+ * Each event type owns two bits in the bitfield: one for the READ
+ * event and one for the WRITE event.
+ *
+ * For this reason, the specific event bit is calculated by adding
+ * the event type identifier (always a multiple of 2, as defined
+ * below) to 0 for READ and 1 for WRITE.
+ *
+ * E.g.
+ * MANAGEMENT_SHIFT = 6; <---- event type identifier
+ * MANAGEMENT_READ = (1 << (6 + 0)), <---- READ event
+ * MANAGEMENT_WRITE = (1 << (6 + 1)) <---- WRITE event
+ *
+ * 'error' and 'file_close' are special and use read/write for different
+ * signals.
+ */
+#define READ_SHIFT 0
+#define WRITE_SHIFT 1
+
+#define SHIFT(_name, _op) (1 << (_name ## _SHIFT + _op ## _SHIFT))
+
+#define SOCKET_SHIFT 0
+#define SOCKET_READ SHIFT(SOCKET, READ)
+#define SOCKET_WRITE SHIFT(SOCKET, WRITE)
+#define TUN_SHIFT 2
+#define TUN_READ SHIFT(TUN, READ)
+#define TUN_WRITE SHIFT(TUN, WRITE)
+#define ERR_SHIFT 4
+#define ES_ERROR SHIFT(ERR, READ)
+#define ES_TIMEOUT SHIFT(ERR, WRITE)
+#ifdef ENABLE_MANAGEMENT
+#define MANAGEMENT_SHIFT 6
+#define MANAGEMENT_READ SHIFT(MANAGEMENT, READ)
+#define MANAGEMENT_WRITE SHIFT(MANAGEMENT, WRITE)
+#endif
+#ifdef ENABLE_ASYNC_PUSH
+#define FILE_SHIFT 8
+#define FILE_CLOSED SHIFT(FILE, READ)
+#endif
unsigned int event_set_status;
--
2.26.3
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
