Hi, On Wed, May 12, 2021 at 03:15:07PM +0200, Arne Schwabe wrote: > the unit tests do not compile under windows since they are missing > the correct ifdef guards
While I totally agree with "WE MUST HAVE MORE #IFDEF!!" (in best
OpenVPN tradition), I do not think that this is the right place or
time.
> diff --git a/tests/unit_tests/openvpn/test_argv.c
> b/tests/unit_tests/openvpn/test_argv.c
> index 3dc470a52..6ab9be53c 100644
> --- a/tests/unit_tests/openvpn/test_argv.c
> +++ b/tests/unit_tests/openvpn/test_argv.c
> @@ -2,7 +2,9 @@
> #include "syshead.h"
>
> #include <stdio.h>
> +#ifdef HAVE_UNISTD_H
> #include <unistd.h>
> +#endif
As far as I can see, all these test modules include "syshead.h", which
already has the unistd.h (with guard!).
So maybe a better version of this patch would be to remove <unistd.h>
and all other includes that are already pulled in by "syshead.h"?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
