Historically we always had -Wno-unused-parameter and -Wno-unused-function enabled along with -Wall.
When we made -Wall a default option, we carried the other two along and made them default too (in 2018). Now the code is much cleaner compared to the past and we do not really require -Wno-unused-parameter and -Wno-unused-function anymore. Actually they may hide really unused functions that we'd need to cleanup. For this reason remove -Wno-unused-parameter and -Wno-unused-function for good from the default CFLAGS. Any new warning should rather be fixed than hidden. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7c2ead6a..a37dc762 100644 --- a/configure.ac +++ b/configure.ac @@ -1224,8 +1224,6 @@ AC_DEFUN([ACL_CHECK_ADD_COMPILE_FLAGS], [ ) ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-stringop-truncation]) -ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-unused-function]) -ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-unused-parameter]) ACL_CHECK_ADD_COMPILE_FLAGS([-Wall]) if test "${enable_pedantic}" = "yes"; then -- 2.32.0 _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel