Hi,

> Not sure where these came from, but here goes:

According to git blame, those dates back to 2012:

https://github.com/OpenVPN/openvpn/commit/4b1a82db0975088dbfe69c2a97f0a96ef972b2a4#diff-f17c6f8c8df2b2934b574e407cbde107338969c6898ce8e8965dc289ae979fc6R97

> S_IRUSR = 0 --> _S_IREAD
> S_IWUSR = 0 --> _S_IWRITE

MSFT docs says that:

"If a value other than some combination of _S_IREAD and _S_IWRITE is
specified for pmode—even if it would specify a valid pmode in another
operating system—or if any value other than the allowed oflag values
is specified, the function generates an assertion in Debug mode and
invokes the invalid parameter handler, as described in Parameter
Validation."

I tried Debug build with --status but haven't seen any assertions.
Anyway, it is clear that passing 0 was incorrect.

> Should fix Trac #1430 but untested (I do not have a setup at hand for msvc 
> build).

If you push your branch to GitHub, it will kick off GitHub Actions
build which produces MSVC-built artifacts.

Built and tested locally, works as expected - status file is created
without "readonly" attribute.

Acked-by: Lev Stipakov <lstipa...@gmail.com>


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to