This patch took at bit of massaging to get in, due to the context
having SSL_CTX_new_ex() which disappeared during 08 v3->v4 -> replaced
by proper context (adding #if OPENSSL_VERSION_NUMBER < 0x30000000L).
I have read Selva's comment about mem leaking, and decided to still
merge it - this OSS 3 thing is work in progress, and I want to get
the later patches in that have ACKs, so the code can get more exposure
(we must not forget to return here and fix it, of course).
I have stared at the code a bit, and given it "make check" treatment -
this now explodes for 3.0.0 in the ncp_testdriver
Unsupported cipher in --data-ciphers: BF-CBC
[ ERROR ] --- Test failed with exception: Segmentation fault(11)
(but I assume that this will be fixed as soon as the legacy provider
stuff gets in). t_lpback.sh still fails, but now with a proper error
message ("Cipher SEED-OFB not supported") - I seem to remember a later
patch fixing the cipher listing part, so SEED-OFB won't even show up
as a candidate.
1.1.1 passes just fine.
Your patch has been applied to the master branch.
commit f40edaa5abe5255710315deacd8c82cdfef12647
Author: Arne Schwabe
Date: Tue Oct 19 20:31:16 2021 +0200
Replace EVP_get_cipherbyname with EVP_CIPHER_fetch
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-By: Max Fillinger <maximilian.fillin...@foxcrypto.com>
Message-Id: <20211019183127.614175-11-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23005.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
