Acked-by: Gert Doering <[email protected]>
Not sure, really, why this did not get enough traction 5 years ago... so
thanks for pushing it :-) - and I understand that Selva did not want to
ACK it.
I have not tested it, just stared a bit at the code (fine) and test
compiled on MinGW (also fine).
Getting rid of the if() statement in tun.c is okay, though the
resulting line is violating our line length... this is a big ugly.
(Also, just passing in "tt->options.dhcp_masq_offset" always (as it
defaults to "0") would do the job fine now...)
Your patch has been applied to the master and release/2.5 branch.
commit 7df6583d76fc2ff485186ede75f00c9b7dc3e42c (master)
commit 93e4f286b906391a21697e44a02a00b871b977ba (release/2.5)
Author: Lev Stipakov
Date: Tue Nov 9 03:59:27 2021 +0200
Use network address for emulated DHCP server as a default
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg23156.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
