Acked-by: Gert Doering <g...@greenie.muc.de>
Exhaustive client- and server-side tests with OpenSSL 1.1.1, 3.0.0
and mbedTLS, on Linux and FreeBSD - nothing to complain about.
Stare-at-code brought up the question on whether
+static inline bool md_defined(const char* mdname)
+{
+ return strcmp(mdname, "none") != 0;
+}
should have a check for "mdname != NULL" - either ASSERT() or
"return mdname != NULL && strcmp(mdname, "none") != 0" style.
Since this works as is, I think, this can go to the followup patch
cleaning up my complaints about 7/9 v4 :-)
Your patch has been applied to the master branch.
commit b39725cf811cbe9334355d4c90990047494a6cc2
Author: Arne Schwabe
Date: Mon Dec 13 16:06:54 2021 +0100
Remove md_kt_t and change cyrpto API to use const char*
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20211213150654.3993358-2-a...@rfc2549.org>
URL:
https://www.mail-archive.com/search?l=mid&q=20211213150654.3993358-2-a...@rfc2549.org
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
