Acked-by: Gert Doering <[email protected]>
I do not see the immediate benefit, but the commit message points toward
future simplification - so it falls under "always init everything
avoids special cases later", which is good :-)
I do not have a test case for this right now (TLS with --cipher none
does not excercise this code path), so I couldn't *really* test it -
running openvpn / p2p without --secret does yield the correct warning
(lots of them), does not crash, and sends nice encapsulated but unecrypted
packets over the wire...
2021-12-13 22:20:09 DEPRECATION: No tls-client or tls-server option in
configuration detected. OpenVPN 2.7 will remove the functionality to run a VPN
without TLS. See the examples section in the manual page for examples of a
similar quick setup with peer-fingerprint.
2021-12-13 22:20:09 ******* WARNING *******: '--cipher none' was specified.
This means NO encryption will be performed and tunnelled data WILL be
transmitted in clear text over the network! PLEASE DO RECONSIDER THIS SETTING!
2021-12-13 22:20:09 ******* WARNING *******: '--auth none' was specified. This
means no authentication will be performed on received packets, meaning you
CANNOT trust that the data received by the remote side have NOT been
manipulated. PLEASE DO RECONSIDER THIS SETTING!
2021-12-13 22:20:09 ******* WARNING *******: All encryption and authentication
features disabled -- All data will be tunnelled as clear text and will not be
protected against man-in-the-middle changes. PLEASE DO RECONSIDER THIS
CONFIGURATION!
maybe this is overdoing it just so slightly, and we should set "warn"
to "false" here...? But anyway, I assume that this will go away soonish
anyway.
Your patch has been applied to the master branch.
commit 02d8f792893965a653e6bc99e039e169ad70bef9
Author: Arne Schwabe
Date: Wed Dec 1 19:07:27 2021 +0100
Initialise kt_cipher even when no crypto is enabled
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg23272.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
