Acked-by: Gert Doering <[email protected]>
Code looks reasonably, and comes with an extensive test suite - so I
did not test "does it configure the same link-mtu for all possible
combinations as the code before that". I did test some basic stuff
(TLS/BF-CBC/SHA1, TLS/AES-256-GCM, TLS/none/none) and it did produce
"different values". BF-CBC matched what the server wanted, with the
same config.
I have left out the hunk that adds "option.h" to test_misc.c - that
looks stray, no change to that test otherwise (maybe it's needed in
a later patch, then I'll notice and re-add it). test_crypto.c also
has this added, and *there* it's definitely needed :-)
As mentioned on IRC, we're losing a few msg(D_MTU_DEBUG, ...) in this
process - do we want to bring them back at some point?
Your patch has been applied to the master branch.
commit 01b7cd44669896d91696e936cc38a2f57bc6081e
Author: Arne Schwabe
Date: Thu Dec 30 18:21:36 2021 +0100
Rework occ link-mtu calculation
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/search?l=mid&[email protected]
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
