Re: [Openvpn-devel] [PATCH] auth_token.c: add NULL initialization

[Arne Schwabe]

Am 07.01.22 um 13:35 schrieb Lev Stipakov:

From: Lev Stipakov <l...@openvpn.net>

This fixes

   error C4703: potentially uninitialized local pointer variable 'b64output' 
used

found by arm64 msvc compiler with SDL enabled.

Not sure why this is not triggered on x86/x64.

Signed-off-by: Lev Stipakov <l...@openvpn.net>
---
  src/openvpn/auth_token.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c
index e8875464..ceae68f6 100644
--- a/src/openvpn/auth_token.c
+++ b/src/openvpn/auth_token.c
@@ -259,7 +259,7 @@ generate_auth_token(const struct user_pass *up, struct 
tls_multi *multi)
      ASSERT(buf_write(&token, &timestamp, sizeof(timestamp)));
      ASSERT(buf_write(&token, hmac_output, sizeof(hmac_output)));

- char *b64output;

+    char *b64output = NULL;
      openvpn_base64_encode(BPTR(&token), BLEN(&token), &b64output);

struct buffer session_token = alloc_buf_gc(

Fine with me

Acked-By: Arne Schwabe <a...@rfc2549.org>


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel