Hi, > A whole patch in the commit message is not very helpful and makes it hard to > read. Why not include this patch + the original, and apply the patch during > build? > > Or just add a pointer to the original file in the changed file so that it > could be diff-ed against if need be,
Yeah, I was not sure what is the best way to indicate difference between this one and original one, so I added it to commit message. Not sure what do you mean by "apply the patch during build" - you can have patches for port sources but I don't think you can patch the port script. Like you proposed I could add a comment to the patched file which points to original one. > These changes look sane though I think this should be a separate commit. I could do that, but then commit without those changes will break the build. -- -Lev _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel