Hi,
On 25/01/2022 17:30, Arne Schwabe wrote:
Am 25.01.22 um 17:27 schrieb Antonio Quartulli:
Hi,
On 21/01/2022 19:57, selva.n...@gmail.com wrote:
diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c
index 35fb0052..b93c680a 100644
--- a/src/openvpn/crypto_openssl.c
+++ b/src/openvpn/crypto_openssl.c
@@ -1073,6 +1073,10 @@ md_kt_name(const char *mdname)
unsigned char
md_kt_size(const char *mdname)
{
+ if (!strcmp("none", mdname))
Since we have it implemented, can we use streq() here?
Cheers,
streq is mainly used in option.c only, almost all other codes uses
strcmp insteads, so not really that strong of an argument.
I thought options.c was part of this project too :-D
To be honest, I think streq() is not really useful, but then we should
either use it consistently or just drop it.
I am in favour of dropping it because including options.h in other .c
files can be quite a nightmare and you don't want that just to use streq().
So I guess we can live with this patch, but should we put on the agenda
wiping streq() for good?
Cheers,
Arne
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
