Acked-by: Gert Doering <[email protected]>

.. though I'm not sure I understand any of this code, or how to trigger
it.  So I've only run client/server tests, and stared at the code changes
for a bit.

I think it actually breaks the original intent, as the "changes per
iteration" variable "entry->delta" is gone now - so this is a semi-NAK,
as in "we need to come back here and fix this".  But I want to move
forward with the frame stuff, and 7/8 can not go in without this.

Can anyone tell me how to actually trigger an "OCC MTU test"?  --mtu-disc 
is doing socket level stuff ("only supported on OSes ... necessary system
call") - so maybe this was broken / inactive already before...

Your patch has been applied to the master branch.

commit fb76954a232decc86e071a76861c1e4fdd2507ab
Author: Arne Schwabe
Date:   Thu Feb 10 17:26:29 2022 +0100

     Use new frame header methods to calculate OCC_MTU_LOAD payload size

     Signed-off-by: Arne Schwabe <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg23750.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to