Stared at code (looks good).
Tested with Richard's config (no more warnings about SHA256, good), and
ran my usual set of client tests (no issues).
I did notice a long standing copy-paste thing in auth_token.c...
msg(M_WARN, "ERROR: --tls-crypt requires HMAC-SHA-256 support.");
.. this should be "--auth-gen-token" not "--tls-crypt", I think... for
the next round of cleanups.
Your patch has been applied to the master branch.
commit af695b53e01035a9137bc78a868cd5410be817f4
Author: Antonio Quartulli
Date: Tue Feb 15 13:31:57 2022 +0100
auth_token/tls_crypt: fix usage of md_valid()
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
Acked-by: Arne Schwabe <a...@rfc2549.org>
Message-Id: <20220215123157.10615-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23793.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
