On 8 Mar 2022, at 15:36, Antonio Quartulli wrote: > On 08/03/2022 15:29, Kristof Provost wrote: >> Theoretically I’d prefer to use the OS header, but I can certainly see the >> upside of not having that dependency. We’ll always have to do the runtime >> check (dco_available()) anyway, so I can certainly live with that. >> >>> p.s. as a side note, the rest of the code contains some "code style" >>> issues. Nothing major, but wanted to mention it (we can discuss on IRC if >>> you want). >>> >> I’m happy to fix that. Do you have a rough list of what’s wrong? >> https://community.openvpn.net/openvpn/wiki/CodeStyle is the authoritative >> style guide, right? > > Correct. Not everything might be there, so feel free to ask for any > clarification on IRC. Your code is already pretty clean actually. > Some things I have seen: > - We tend to avoid "if (a == NULL)" (or "!= 0") in favor of just "if (a)"; > - We avoid spaces after the cast operator; > - we always use brackets {} for one-line blocks; > Thanks!
Most of those are probably because I’m used to FreeBSD’s style (https://www.freebsd.org/cgi/man.cgi?query=style&apropos=0&sektion=0&manpath=FreeBSD+13.0-RELEASE+and+Ports&arch=default&format=html), but consistency is important. I’ll update the patch (and also address the SET_TIMEOUT thing) soon. I’ve got a bit of travel coming up, so I’m not quite sure when it’ll be though. Best regards, Kristof _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
