Acked-by: Gert Doering <g...@greenie.muc.de>
We've, indeed, not been very thorough in following our own formatting
rules... seems a few tabs-vs-spaces snuck in, and there were some
misunderstanding on certain constructs (like, function return types).
As discussed on IRC, we do a Great Reformatting now, and then require
all core contributors to send clean patches only, aka "use the pre-commit
hook that Heiko has developed". Which only works if the underlying tree
is clean - which this achieves.
I've gone through the changes with "git show -w" - this is mainly
"function return on separate line", "C++ comment", "#else with comment",
but no actual code changes.
Without "-w", it's a number of space-vs-tab, "char *foo" vs. "char* foo",
all minor things, but uncrustify has no mercy there (I do not find all
changes aesthetically "better" than before, especially the msg() stuff,
but unless someone finds an uncrustify option to do these differently,
consistency trumps personal aesthetics).
I have also compile + t_client tested, for good measure (all OK).
Your patch has been applied to the master branch.
commit abe49856d81f51136d543539202a0bf8fb946474
Author: David Sommerseth
Date: Wed Apr 20 16:30:50 2022 +0200
The Great Reformatting of 2022
Signed-off-by: David Sommerseth <dav...@openvpn.net>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20220420143050.52790-1-open...@sf.lists.topphemmelig.net>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24123.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
